| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jun 2011 01:15:02 +0400 From: Alexey Khoroshilov <khoroshilov@...ras.ru> To: Christoph Hellwig <hch@...era.com> Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>, Anton Salikhmetov <alexo@...era.com>, Al Viro <viro@...iv.linux.org.uk>, roman@...istech.com, linux-kernel@...r.kernel.org, ldv-project@...ras.ru Subject: [PATCH 2/2] hfsplus: Fix double iput of the same inode in hfsplus_fill_super() There is a misprint in resource deallocation code on error path in hfsplus_fill_super(): the sbi->alloc_file inode is iput twice, while the root inode in not iput at all. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> --- fs/hfsplus/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index 07a0502..8bfbd38 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c @@ -504,7 +504,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent) out_put_hidden_dir: iput(sbi->hidden_dir); out_put_root: - iput(sbi->alloc_file); + iput(root); out_put_alloc_file: iput(sbi->alloc_file); out_close_cat_tree: -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists