linux-kernel - [PATCH] [SCSI] mpt2sas: Remove duplicate code in mpt2sas_base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1308909569-5293-1-git-send-email-jkacur@redhat.com>
Date:	Fri, 24 Jun 2011 11:59:29 +0200
From:	John Kacur <jkacur@...hat.com>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	lkml <linux-kernel@...r.kernel.org>
Cc:	Eric Moore <eric.moore@....com>, linux-scsi@...r.kernel.org,
	John Kacur <jkacur@...hat.com>
Subject: [PATCH] [SCSI] mpt2sas: Remove duplicate code in mpt2sas_base_attach

Remove this duplicate code I found by inspection.

Signed-off-by: John Kacur <jkacur@...hat.com>
---
 drivers/scsi/mpt2sas/mpt2sas_base.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index efa0255..2660b3c 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -3933,13 +3933,6 @@ mpt2sas_base_attach(struct MPT2SAS_ADAPTER *ioc)
 		goto out_free_resources;
 	}
 
-	if (!ioc->base_cmds.reply || !ioc->transport_cmds.reply ||
-	    !ioc->scsih_cmds.reply || !ioc->tm_cmds.reply ||
-	    !ioc->config_cmds.reply || !ioc->ctl_cmds.reply) {
-		r = -ENOMEM;
-		goto out_free_resources;
-	}
-
 	init_completion(&ioc->shost_recovery_done);
 
 	for (i = 0; i < MPI2_EVENT_NOTIFY_EVENTMASK_WORDS; i++)
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/