linux-kernel - Re: [PATCH] SOUND: Fix non-ISA_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2011 15:14:59 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Jaroslav Kysela <perex@...ex.cz>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	linux-mips@...ux-mips.org
Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

At Fri, 24 Jun 2011 14:08:18 +0100,
Ralf Baechle wrote:
> 
> On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote:
> 
> > >  o The drivers/media/radio/Kconfig part should be applied for 3.0 and
> > >    maybe -stable.
> > 
> > Yes, this will be good.
> 
> I just tested that segment only and it works as expected.  Will repost in
> a minute.

Great, thanks.

> > >  o The sound/isa/Kconfig part is basically only fixing the dependency for
> > >    the Adlib driver allowing it to be built on non-ISA_DMA_API system and
> > >    is material for the next release after 3.0.
> > 
> > Any serious reason that snd-adlib must be built even with ISA=n?
> 
> Definately not.
> 
> > As the device is really present only for ISA, it doesn't make much
> > sense to build this even though the driver itself doesn't need
> > ISA_DMA_API.
> 
> I'm not aware of any systems that could use the Adlib in a ISA=n
> environment.  That's why my patch left the dependency on ISA untouched.

OK, but this would just make things complex, I'm afraid.

Practically the only user of snd-adlib is the old x86 with ISA
support, which implies ISA_DMA_API=y, too.  Thus I don't want to touch
sound/isa/Kconfig just for snd-adlib being built for some funky
Kconfig setup :)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/