linux-kernel - Re: [PATCH v2 21/22] KVM: MMU: mmio page fault support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E03F0AE.8010700@cn.fujitsu.com>
Date:	Fri, 24 Jun 2011 10:04:30 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
CC:	Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
	KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 21/22] KVM: MMU: mmio page fault support

On 06/24/2011 04:13 AM, Marcelo Tosatti wrote:

>> No, not all no mmio spte is considered a genuine EPT misconfig, as the above
>> case, we can get !is_mmio_spte(), but it is not the genuine EPT misconfig
>> since it is caused by shadow page zapped
> 
> I mean it must be
> 
> if (is_mmio_spte(spte))
>     handle_mmio
> if (spte == spte_not_present) /* race, let CPU refault */
>     return
> handle EPT misconf
> 

The patch already did it as you say :p

if (is_mmio_spte(spte))
	return handle_mmio
if (spte_present(spte))
	return handle EPT misconfig

return page fault path /*I will fix it, let cpu refault instead*/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/