[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1308881159.30166.0.camel@lade.trondhjem.org>
Date: Thu, 23 Jun 2011 22:05:59 -0400
From: Trond Myklebust <Trond.Myklebust@...app.com>
To: "J. R. Okajima" <hooanon05@...oo.co.jp>
Cc: Paul Gortmaker <paul.gortmaker@...driver.com>, stable@...nel.org,
linux-kernel@...r.kernel.org, stable-review@...nel.org
Subject: Re: [34-longterm 100/247] NFS: fix the return value of
nfs_file_fsync()
On Fri, 2011-06-24 at 11:03 +0900, J. R. Okajima wrote:
> Paul Gortmaker:
> > By the commit af7fa16 2010-08-03 NFS: Fix up the fsync code
> > close(2) became returning the non-zero value even if it went well.
> > nfs_file_fsync() should return 0 when "status" is positive.
> >
> > [PG: in 34, nfs_file_fsync is just a wrapper around nfs_do_fsync,
> > so the related code and actual change lands in nfs_do_fsync here.]
>
> In these 247 patches, I could not find the backport of
> af7fa16 2010-08-03 NFS: Fix up the fsync code
> If you bring the commit af7fa16 into 2.6.34.10, then you will need this
> one (0702099bd in upstream) too. Otherwise I am afraid it is
> unnecessary.
> But I'd ask a reply from Trond Myklebust.
I agree.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@...app.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists