linux-kernel - Re: [patch 1/5] i8253: Create common clockevent implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinwpK=TFFexbeBeqXz-s=ouBK9gEg@mail.gmail.com>
Date:	Sat, 25 Jun 2011 22:03:03 +0200
From:	Stijn Devriendt <highguy@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Ingo Molnar <mingo@...e.hu>,
	John Stultz <john.stultz@...aro.org>
Subject: Re: [patch 1/5] i8253: Create common clockevent implementation

> +/*
> + * Initialize the conversion factor and the min/max deltas of the clock event
> + * structure and register the clock event source with the framework.
> + */
> +void __init clockevent_i8253_init(bool oneshot)
> +{
> +       if (oneshot)
> +               i8253_clockevent.features |= CLOCK_EVT_FEAT_ONESHOT;
> +       /*
> +        * Start pit with the boot cpu mask. x86 might make it global
> +        * when it is used as broadcast device later.
> +        */
> +       i8253_clockevent.cpumask = cpumask_of(smp_processor_id());
> +
> +       clockevents_config_and_register(&i8253_clockevent, PIT_TICK_RATE,
> +                                       0xF, 0x7FFF);
> +}
> +#endif
>
Both this function and the i8253_clockevent declaration seem to be missing
from include/linux/i8253.h causing compile failures for at least x86.

I was just trying to compile tip of
git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git

Should be fixed by applying the following patch.

commit 0c24072a8d580acd5b4fc57009b72b217c0f23d9
Author: Stijn Devriendt <HIGHGuY@...il.com>
Date:   Sat Jun 25 22:04:53 2011 +0200

    Fix missing declarations of i8253.

    Signed-off-by: Stijn Devriendt <HIGHGuY@...il.com>

diff --git a/include/linux/i8253.h b/include/linux/i8253.h
index 0770fc5..e6c032f 100644
--- a/include/linux/i8253.h
+++ b/include/linux/i8253.h
@@ -22,6 +22,10 @@

 extern raw_spinlock_t i8253_lock;

+extern struct clock_event_device i8253_clockevent;
+
 extern void setup_pit_timer(void);

+extern void clockevent_i8253_init(bool oneshot);
+
 #endif /* __LINUX_I8253_H */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/