linux-kernel - [PATCH] rtc: Check return value of twl_rtc_write_u8() in twl_rtc_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1106252300490.23991@swampdragon.chaosbits.net>
Date:	Sat, 25 Jun 2011 23:05:09 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	rtc-linux@...glegroups.com
cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, Alexandre Rusev <source@...sta.com>,
	"George G. Davis" <gdavis@...sta.com>, source@...sta.com
Subject: [PATCH] rtc: Check return value of twl_rtc_write_u8() in
 twl_rtc_set_time()

In drivers/rtc/rtc-twl.c:twl_rtc_set_time() we forget to save the
return value of the call to
twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG);
in 'ret', making the test of 'ret < 0' dead code since 'ret' then
couldn't possibly have changed since the last test just a few lines
above. It also makes us not detect failures from that specific
twl_rtc_write_u8() call.

Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
 drivers/rtc/rtc-twl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index f9a2799..9a81f77 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -275,7 +275,7 @@ static int twl_rtc_set_time(struct device *dev, struct rtc_time *tm)
 		goto out;
 
 	save_control &= ~BIT_RTC_CTRL_REG_STOP_RTC_M;
-	twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG);
+	ret = twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG);
 	if (ret < 0)
 		goto out;
 
-- 
1.7.5.2


-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/