linux-kernel - Re: [rfc patch] x86,apic: fix DEBUG_PREEMPT gripe when booting with threadirqs=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110626104521.GE11093@elte.hu>
Date:	Sun, 26 Jun 2011 12:45:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Galbraith <mgalbraith@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [rfc patch] x86,apic: fix DEBUG_PREEMPT gripe when booting with
 threadirqs=1


* Mike Galbraith <mgalbraith@...e.de> wrote:

> x86,apic: fix DEBUG_PREEMPT gripe when booting with threadirqs=1
> 
> If CONFIG_PREEMPT and CONFIG_INTR_REMAP are both set, and a box is
> booted with threadirqs, the gripe below is emitted.  It was suggested
> that native_smp_prepare_cpus() shouldn't need to be run with preemption
> disabled, and indeed, box boots with no hint of trouble.  Remove it.

Would also require a careful review of the code we take out of 
preempt protection now - have you done that by any chance? (if not, 
mind doing it?)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/