linux-kernel - Re: linux-next: Tree for June 24 (mtd + of)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2011 00:09:16 +0400
From:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
To:	dedekind1@...il.com
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Vitaly Wool <vwool@...mvista.com>
Subject: Re: linux-next: Tree for June 24 (mtd + of)

On 6/26/11, Artem Bityutskiy <dedekind1@...il.com> wrote:
> On Sun, 2011-06-26 at 00:11 -0600, Grant Likely wrote:
>> > 3.0-rc4 does not have this build error when I use the .config file with
>> > it...
>> > however, I think that 3.0-rc4 also does not build ofpart.ko as it
>> > should.
>> >
>> > Looks to me like changes in drivers/mtd/{Kconfig && Makefile} caused
>> > this
>> > build error.
>>
>> The following commit in linux-next appears to be the culprit:
>>
>> commit 1a6bc893044b961caae1c5a9c6c2065e608da427
>> Author: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
>> Date:   Sun May 29 21:32:33 2011 +0400
>>
>>     mtd: prepare to convert of_mtd_parse_partitions to partition parser
>>
>>     Prepare to convert of_mtd_parse_partitions() to usual partitions
>> parser:
>>     1) Register ofpart parser
>>     2) Internally don't use passed device for error printing
>>     3) Add device_node to mtd_part_parser_data struct
>>     4) Move of_mtd_parse_partitions from __devinit to common text section
>>     5) add ofpart to the default list of partition parsers
>>
>>     Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
>>     Signed-off-by: Artem Bityutskiy <dedekind1@...il.com>
>>
>> It adds a module_init() call to ofpart.c which does not work the way
>> that ofpart.c is linked to mtdcore.o.  Seems like that commit series
>> still needs work.
>
> OK, let's ask Dmitry to take a look at this.

Yes, I've forgot about this... ofpart can be made a simple module now.
I'll send two patches in five minutes or so.

-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/