linux-kernel - Re: [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTik7kNzrCs9yv2DxTZykWGLw_QDDnw@mail.gmail.com>
Date:	Mon, 27 Jun 2011 11:26:55 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Valdis.Kletnieks@...edu
Cc:	linux-kernel@...r.kernel.org,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator

2011/6/23  <Valdis.Kletnieks@...edu>:
> On Thu, 23 Jun 2011 10:15:51 +0800, Axel Lin said:
>> Base on Mark's comment [1], I make the Kconfig entry invisible to users.
>
>> +config TPS65911_COMPARATOR
>> +     tristate
>> +
>
> This can't possibly be right by itself- how would it ever get enabled, without
> a SELECT pointing at it or a user selecting it?
>
> Is there a follow-on patch that adds a user?
>

I was thinking the driver that adds "tps65911-comparator" device should
select CONFIG_TPS65911_COMPARATOR symbol.

Or maybe it is ok just make config TPS65911_COMPARATOR visible to users and
make it depend on MFD_TPS65910.

Comments?

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/