linux-kernel - Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E089730.1080306@gnu.org>
Date:	Mon, 27 Jun 2011 10:44:00 -0400
From:	Pavel Roskin <proski@....org>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	Rafał Miłecki <zajec5@...il.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-wireless@...r.kernel.org, linux-next@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>

On 06/27/2011 10:24 AM, Alexey Dobriyan wrote:
> 2011/6/27 Rafał Miłecki<zajec5@...il.com>:
>> 2011/6/26 Geert Uytterhoeven<geert@...ux-m68k.org>:
>>> m68k allmodconfig:
>>>
>>> drivers/bcma/main.c: In function ‘bcma_release_core_dev’:
>>> drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’
>>
>> We already include slab.h in:
>> host_pci.c
>> scan.c
>> sprom.c
>>
>> Maybe we can just include this in bcma.h as a better solution?
>
> It isn't better solution.
> It results in situation where unnecessary inclusion will be done.
> Maybe it's not the case now, but it will be in future.

I agree.  kfree() is used in main.c, not in bcma.h.  There is no need 
for all files that include bcma.h to include linux/slab.h, especially 
(but not only) because bcma.h is not a private header.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/