linux-kernel - Re: [PATCH 11/12] MISC: IOC4: Fix section mismatch / race condition.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1106271056200.28116@pkunk.americas.sgi.com>
Date:	Mon, 27 Jun 2011 10:57:21 -0500 (CDT)
From:	Brent Casavant <bcasavan@....com>
To:	Ralf Baechle <ralf@...ux-mips.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
	linux-mips@...ux-mips.org
Subject: Re: [PATCH 11/12] MISC: IOC4: Fix section mismatch / race
 condition.

On Mon, 27 Jun 2011, Ralf Baechle wrote:

> WARNING: drivers/misc/ioc4.o(.data+0x144): Section mismatch in reference from the variable ioc4_load_modules_work to the function .devinit.text:ioc4_load_modules()
> The variable ioc4_load_modules_work references
> the function __devinit ioc4_load_modules()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
> 
> This one is potencially fatal; by the time ioc4_load_modules is invoked
> it may already have been freed.  For that reason ioc4_load_modules_work
> can't be turned to __devinitdata but also because it's referenced in
> ioc4_exit.
> 
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> To: Brent Casavant <bcasavan@....com>
> To: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-mips@...ux-mips.org
> ---
>  drivers/misc/ioc4.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/ioc4.c b/drivers/misc/ioc4.c
> index 668d41e..df03dd3 100644
> --- a/drivers/misc/ioc4.c
> +++ b/drivers/misc/ioc4.c
> @@ -270,7 +270,7 @@ ioc4_variant(struct ioc4_driver_data *idd)
>  	return IOC4_VARIANT_PCI_RT;
>  }
>  
> -static void __devinit
> +static void
>  ioc4_load_modules(struct work_struct *work)
>  {
>  	request_module("sgiioc4");
> -- 
> 1.7.4.4
> 

Acked-by: Brent Casavant <bcasavan@....com>

-- 
Brent Casavant
Silicon Graphics International
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/