| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1106272223070.30245@swampdragon.chaosbits.net> Date: Mon, 27 Jun 2011 22:26:14 +0200 (CEST) From: Jesper Juhl <jj@...osbits.net> To: Al Viro <viro@...iv.linux.org.uk> cc: Rik Faith <faith@...hat.com>, Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org Subject: [PATCH][Resend] audit: Always follow va_copy() with va_end() A call to va_copy() should always be followed by a call to va_end() in the same function. In kernel/autit.c::audit_log_vformat() this is not always done. This patch makes sure va_end() is always called. Signed-off-by: Jesper Juhl <jj@...osbits.net> --- kernel/audit.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) Last submitted Dec 24 2010 with no response, so resending. diff --git a/kernel/audit.c b/kernel/audit.c index 9395003..67c2582 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1257,12 +1257,13 @@ static void audit_log_vformat(struct audit_buffer *ab, const char *fmt, avail = audit_expand(ab, max_t(unsigned, AUDIT_BUFSIZ, 1+len-avail)); if (!avail) - goto out; + goto out_va_end; len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2); } - va_end(args2); if (len > 0) skb_put(skb, len); +out_va_end: + va_end(args2); out: return; } -- 1.7.5.2 -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists