[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1309159583-11339-1-git-send-email-bigeasy@linutronix.de>
Date: Mon, 27 Jun 2011 09:26:22 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Grant Likely <grant.likely@...retlab.ca>
Cc: linux-kernel@...r.kernel.org, sodaville@...utronix.de
Subject: [PATCH 1/2] gpio/gpio-generic: read set register for caching if available
The ->data is a shadow copy which is used during the ->set callback in
order to avoid a read of the register before write.
If ->reg_set is set then we write to this location therefore we should
cache that value.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
---
drivers/gpio/gpio-generic.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index 231714d..9f8b5c6 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -398,7 +398,10 @@ int __devinit bgpio_init(struct bgpio_chip *bgc,
if (ret)
return ret;
- bgc->data = bgc->read_reg(bgc->reg_dat);
+ if (bgc->reg_set)
+ bgc->data = bgc->read_reg(bgc->reg_set);
+ else
+ bgc->data = bgc->read_reg(bgc->reg_dat);
return ret;
}
--
1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists