linux-kernel - Re: [patch 14/22] memcg: fix direct softlimit reclaim to be called in limit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110628170649.87043e05.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Tue, 28 Jun 2011 17:06:49 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, nishimura@....nes.nec.co.jp,
	yinghan@...gle.com, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch 14/22] memcg: fix direct softlimit reclaim to be called
 in limit path

On Tue, 28 Jun 2011 10:08:47 +0200
Michal Hocko <mhocko@...e.cz> wrote:

> I am sorry, that I am answering that late but I didn't get to this
> sooner.
> 
> On Mon 27-06-11 16:18:12, Andrew Morton wrote:
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> > 
> > commit d149e3b ("memcg: add the soft_limit reclaim in global direct
> > reclaim") adds a softlimit hook to shrink_zones().  By this, soft limit is
> > called as
> > 
> >    try_to_free_pages()
> >        do_try_to_free_pages()
> >            shrink_zones()
> >                mem_cgroup_soft_limit_reclaim()
> > 
> > Then, direct reclaim is memcg softlimit hint aware, now.
> > 
> > But, the memory cgroup's "limit" path can call softlimit shrinker.
> > 
> >    try_to_free_mem_cgroup_pages()
> >        do_try_to_free_pages()
> >            shrink_zones()
> >                mem_cgroup_soft_limit_reclaim()
> > 
> > This will cause a global reclaim when a memcg hits limit.
> 
> Sorry, I do not get it. How does it cause the global reclaim? Did you
> mean soft reclaim?
> 

yes. soft reclaim does global reclaim (in some means). 

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/