linux-kernel - Re: [PATCH 02/11] dynamic_debug: trim source-path prefix from dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikjrf6kQcobm1hL7DqxK8iJqV5kjw@mail.gmail.com>
Date:	Tue, 28 Jun 2011 12:08:46 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	linux-kernel@...r.kernel.org, gnb@...h.org, jbaron@...hat.com,
	gregkh@...e.de
Subject: Re: [PATCH 02/11] dynamic_debug: trim source-path prefix from dynamic_debug/control

On Tue, Jun 28, 2011 at 9:09 AM, Jim Cromie <jim.cromie@...il.com> wrote:
>
> Skip past unchanging absolute source-path prefix to print a path
> thats relative to kernel source's root-dir.  This makes the file
> easier to read without a wide screen.  For example:
>
> kernel/freezer.c:128 [freezer]cancel_freezing - "  clean up: %s\012"
>
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  lib/dynamic_debug.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index a3b08d5..eb08a2f 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -601,6 +601,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
>        struct ddebug_iter *iter = m->private;
>        struct _ddebug *dp = p;
>        char flagsbuf[8];
> +       const int offset = strlen(__FILE__) - strlen("lib/dynamic_debug.c");
>
>        if (verbose)
>                printk(KERN_INFO "%s: called m=%p p=%p\n",
> @@ -613,7 +614,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
>        }
>
>        seq_printf(m, "%s:%u [%s]%s %s \"",
> -                  dp->filename, dp->lineno,
> +                  dp->filename + offset, dp->lineno,
>                   iter->table->mod_name, dp->function,
>                   ddebug_describe_flags(dp, flagsbuf, sizeof(flagsbuf)));
>        seq_escape(m, dp->format, "\t\r\n\"");

The above will break the output generated for out-of-tree kernel
modules that use the dynamic debug facility.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/