linux-kernel - Re: [PATCH] perf: removed a non-existent event "L1-icache-prefetches" for AMD processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1309258063.6701.198.camel@twins>
Date:	Tue, 28 Jun 2011 12:47:43 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Zhengyu He <zhengyuh@...gle.com>
Cc:	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	Stephane Eranian <eranian@...gle.com>,
	Venkatesh Pallipadi <venki@...gle.com>,
	linux-kernel@...r.kernel.org,
	Robert Richter <robert.richter@....com>,
	Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH] perf: removed a non-existent event
 "L1-icache-prefetches" for AMD processors

On Mon, 2011-06-27 at 14:58 -0700, Zhengyu He wrote:
> According to AMD's "BIOS and Kernel Developer's Guide for AMD NPT Family
> 0Fh Processors"
> (http://support.amd.com/us/Processor_TechDocs/32559.pdf), 0x4B is for
> prefetch instructions dispatched, and 0x14B is for the load prefetch
> instructions including Pretech and PrefetchT0/T1/T2. No event for the
> instructions preteched into L1I cache is found.
> 
> Signed-off-by: Zhengyu He <zhengyuh@...gle.com>

Hmm, indeed, its prefetch instructions issues, but not instruction
prefetches, Robert, Andre agreed?

> ---
>  arch/x86/kernel/cpu/perf_event_amd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/perf_event_amd.c b/arch/x86/kernel/cpu/perf_event_amd.c
> index fe29c1d..3b7f21d 100644
> --- a/arch/x86/kernel/cpu/perf_event_amd.c
> +++ b/arch/x86/kernel/cpu/perf_event_amd.c
> @@ -29,7 +29,7 @@ static __initconst const u64 amd_hw_cache_event_ids
>  		[ C(RESULT_MISS)   ] = -1,
>  	},
>  	[ C(OP_PREFETCH) ] = {
> -		[ C(RESULT_ACCESS) ] = 0x014B, /* Prefetch Instructions :Load */
> +		[ C(RESULT_ACCESS) ] = 0,
>  		[ C(RESULT_MISS)   ] = 0,
>  	},
>   },

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/