linux-kernel - [PATCH 1/2] ideapad-laptop: Ignore an unused VPC notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1309268154-6872-1-git-send-email-kengyu@canonical.com>
Date:	Tue, 28 Jun 2011 14:35:53 +0100
From:	Keng-Yu Lin <kengyu@...onical.com>
To:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	ike.pan@...onical.com, vanhoof@...onical.com,
	kent.lin@...onical.com, sylee@...onical.com,
	Keng-Yu Lin <kengyu@...onical.com>
Subject: [PATCH 1/2] ideapad-laptop: Ignore an unused VPC notification

BIOS fires notifications in a constant period with VPC bit 1 set when the
power cord is unplugged.

This event is not known yet to have any effect, but it makes the
call to sparse_keymap_report_event() and generates many KEY_UNKNOWNs.

This causes the userspace (Gnome Power Manager in my case) unable
to enter the idle mode. As the result there is no screensaver showing up,
no dim backlight, etc.

Signed-off-by: Keng-Yu Lin <kengyu@...onical.com>
---
 drivers/platform/x86/ideapad-laptop.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index bfdda33..820f013 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -463,7 +463,8 @@ static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
 				ideapad_sync_rfk_state(adevice);
 			else if (vpc_bit == 4)
 				read_ec_data(handle, 0x12, &vpc2);
-			else
+			else if (vpc_bit == 1) {
+			} else
 				ideapad_input_report(priv, vpc_bit);
 		}
 	}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/