linux-kernel - Re: [PATCH 1/3] char drivers: ramoops default platform device for module parameter use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZCVvupUpFzRumgaNO4BL64Ysc3N3CrV+AWEdV3hXF1jLw@mail.gmail.com>
Date:	Tue, 28 Jun 2011 20:56:56 +0300
From:	Daniel Baluta <daniel.baluta@...il.com>
To:	Sergiu Iordache <sergiu@...omium.org>
Cc:	Marco Stornelli <marco.stornelli@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Ahmed S. Darwish" <darwish.07@...il.com>,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] char drivers: ramoops default platform device for
 module parameter use

> +struct platform_device *ramoops_device;

This should be static.

> +
>  static int __init ramoops_init(void)
>  {
> +       /*
> +        * If mem_address and mem_size are set (i.e. the module parameters
> +        * are used) then a default platform driver is created
> +        * as there is no need to configure the platform data elsewhere.
> +        */
> +       if (mem_address && mem_size) {
You should get back to this check after introducing record_size.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/