linux-kernel - Re: [PATCH v3] Add support for the Philips SA56004 temperature sensor.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1309285188.12139.1.camel@groeck-laptop>
Date:	Tue, 28 Jun 2011 11:19:48 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Fubo Chen <fubo.chen@...il.com>
CC:	"Stijn Devriendt (sdevrien)" <sdevrien@...co.com>,
	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] Add support for the Philips SA56004 temperature
 sensor.

On Tue, 2011-06-28 at 13:50 -0400, Fubo Chen wrote:
> On Mon, Jun 27, 2011 at 9:04 AM, Stijn Devriendt (sdevrien)
> <sdevrien@...co.com> wrote:
> >> On Mon, Jun 6, 2011 at 12:40 PM,  <sdevrien@...co.com> wrote:
> >> > +       } else
> >> > +       if (man_id == 0xA1) { /*  NXP Semiconductor/Philips */
> >>
> >> No kernel coder writes like this. Has this ever been run through
> >> checkpatch ?
> > It has. Unfortunately this is just the coding style in the whole
> > driver. I believe it's better to have a consistent file rather
> > than 3 different styles.
> 
> Makes sense to me. By the way, it's not forbidden to clean up unusual
> coding style from other developers.
> 
Yes, but as separate patch. Please feel free to submit such a patch.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/