linux-kernel - Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110628215157.GL15795@trinity.fluff.org>
Date:	Tue, 28 Jun 2011 22:51:57 +0100
From:	Ben Dooks <ben-i2c@...ff.org>
To:	Alexander Stein <alexander.stein@...tec-electronic.com>
Cc:	Jean Delvare <khali@...ux-fr.org>, Ben Dooks <ben-linux@...ff.org>,
	Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is
	received

On Tue, Jun 28, 2011 at 11:43:39AM +0200, Alexander Stein wrote:
> Doing so would spam the kernel log for each i2cdetect run and
> device probe.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tec-electronic.com>

ok, will add to fixes for -rc.

> ---
>  drivers/i2c/busses/i2c-eg20t.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
> index 8abfa4a..97110f7 100644
> --- a/drivers/i2c/busses/i2c-eg20t.c
> +++ b/drivers/i2c/busses/i2c-eg20t.c
> @@ -345,7 +345,7 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
>  	reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
>  
>  	if (reg_val != 0) {
> -		pch_err(adap, "return%d\n", -EPROTO);
> +		pch_dbg(adap, "return%d\n", -EPROTO);
>  		return -EPROTO;
>  	}
>  
> -- 
> 1.7.3.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben Dooks, ben@...ff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/