linux-kernel - Re: missing compat-ioctl for CDROM_DRIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110629125117.GA5739@sig21.net>
Date:	Wed, 29 Jun 2011 14:51:17 +0200
From:	Johannes Stezenbach <js@...21.net>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: missing compat-ioctl for CDROM_DRIVE_STATUS + FDGETPRM

On Wed, Jun 29, 2011 at 02:30:42PM +0200, Arnd Bergmann wrote:
> On Wednesday 29 June 2011, Johannes Stezenbach wrote:
> > Sorry for very slow reply.  I think qemu's use of these ioctls
> > to probe if the device is a cdrom or floppy is valid, so instead
> > of adding a stat() call to check for block device in qemu, I think
> > it is better to silence the warning in the kernel.
> 
> Well, correct or not, it will keep causing annoying messages on
> old kernels, so why not do both?

OK, I'll send a patch for qemu, too.

> > Do I get it right that just adding two IGNORE_IOCTL() to
> > the ioctl_pointer array in linux/fs/compat_ioctl.c is sufficient,
> > like in commit 3f001711?
> 
> Yes.
> 
> > I.e. these ioctls are handled for block devices earlier
> > in compat_sys_ioctl()?
> 
> Right. We always first ask the driver, and then search the lookup table
> when the driver does not know how to handle it in compat mode.

Good, I'll send a patch soon.


Thanks,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/