linux-kernel - Re: [PATCH 0/3] aat2870: Adding mfd, backlight and regulator drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1309356412-23881-1-git-send-email-jinyoungp@nvidia.com>
Date:	Wed, 29 Jun 2011 23:06:49 +0900
From:	Jin Park <jinyoungp@...dia.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Richard Purdie <rpurdie@...ys.net>, Liam Girdwood <lrg@...com>,
	linux-kernel@...r.kernel.org, Jin Park <jinyoungp@...dia.com>
Subject: Re: [PATCH 0/3] aat2870: Adding mfd, backlight and regulator drivers

Changing subject because the patch was separated.
Adding relevant maintainers for backlight and regulator.

Hi Samuel,

> Before reviewing this patch, could you please do the following:
> 
> 1) Split it into 3 actual patches: the MFD one, the regulator one and the
> backlight one.
I have separated the patch to mfd, backlight and regulator.

> 2) Add the relevant maintainers (See MAINTAINERS) if you want to get a proper
> regulator and backlight driver review.
I submitting the patches with relevant maintainers.

> You also need to take the io_lock mutex here, to prevent someone else to write
> a different value to your register between your read and write.
> So what you typically want is an unlocked version of aat2870_[read|write]
> (let's say we call it __aat2870_[read|write]). Then your aat2870_[read|write]
> become wrappers around the __aat2870_[read|write] with the lock taken. And
> your update_bits routine can use __aat2870_[read|write] with the lock taken
> from the beginning.
I have modified mfd driver according to your comment.

Thanks,
Jin.

Jin Park (3):
  mfd: aat2870: Add AAT2870 mfd driver
  backlight: aat2870: Add AAT2870 backlight driver
  regulator: aat2870: Add AAT2870 regulator driver

 drivers/mfd/Kconfig                   |   10 +
 drivers/mfd/Makefile                  |    1 +
 drivers/mfd/aat2870-core.c            |  534 +++++++++++++++++++++++++++++++++
 drivers/regulator/Kconfig             |    7 +
 drivers/regulator/Makefile            |    1 +
 drivers/regulator/aat2870-regulator.c |  264 ++++++++++++++++
 drivers/video/backlight/Kconfig       |    7 +
 drivers/video/backlight/Makefile      |    1 +
 drivers/video/backlight/aat2870_bl.c  |  246 +++++++++++++++
 include/linux/mfd/aat2870.h           |  181 +++++++++++
 10 files changed, 1252 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mfd/aat2870-core.c
 create mode 100644 drivers/regulator/aat2870-regulator.c
 create mode 100644 drivers/video/backlight/aat2870_bl.c
 create mode 100644 include/linux/mfd/aat2870.h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/