linux-kernel - Re: [PATCH 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jun 2011 11:23:11 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Kirill Smelkov <kirr@....spb.ru>
cc:	matt mooney <mfm@...eddisk.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	USB list <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c

On Wed, 29 Jun 2011, Kirill Smelkov wrote:

> > Apart from that one issue,
> > 
> > Acked-off-by: Alan Stern <stern@...land.harvard.edu>
> 
> Thanks.
> 
> What should we do with this patch now? Should I put
> 
> 
>     Copyright (C) 2007 by Alan Stern
> 
> there? Or something else?

Yes, put that in.

> Or maybe drop that copyright notice altogether becase usually it gets
> outdated very quickly, and who made what is visible through git
> log/blame?

Copyright information is important, and it must be present in the 
actual file -- not somewhere else (such as a changelog).

> I'm ok with any case, please just tell me how to proceed.
> 
> 
> And what about main "[PATCH v2 2/2] USB: EHCI: Allow users to override
> 80% max periodic bandwidth"?
> 
> Was it Acked together with this one, or not and review is pending?
> Curious because I'm new here...

I haven't taken the time to review it yet, sorry...

Mostly it looks okay.  In store_uframe_periodic_max(), you can use 
kstrtouint() instead of sscanf() -- that seems to be the trend these 
days.

Also, when decreasing the schedule limit, do you think it is really 
necessary to check that the current allocation doesn't exceed the new 
limit?  I think it would be sufficient to apply the new limit just to 
new bandwidth allocation requests.  After all, this API is meant for 
experts only.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/