linux-kernel - Re: [PATCH 1/4] um: Fix _FORTIFY_SOURCE=2 support for kernel modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jun 2011 18:37:54 +0300
From:	Vitaliy Ivanov <vitalivanov@...il.com>
To:	Richard Weinberger <richard@....at>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [PATCH 1/4] um: Fix _FORTIFY_SOURCE=2 support for kernel modules

On Tue, Jun 28, 2011 at 1:15 AM, Richard Weinberger <richard@....at> wrote:
> When UML is compiled with _FORTIFY_SOURCE we have to
> export all _chk() functions which are used in modules.
> For now it's only the case for __sprintf_chk().
>
> Tested-by: Florian Fainelli <florian@...nwrt.org>
> Reported-by: Florian Fainelli <florian@...nwrt.org>
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  arch/um/os-Linux/user_syms.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/um/os-Linux/user_syms.c b/arch/um/os-Linux/user_syms.c
> index 05f5ea8..45ffe46 100644
> --- a/arch/um/os-Linux/user_syms.c
> +++ b/arch/um/os-Linux/user_syms.c
> @@ -113,3 +113,8 @@ EXPORT_SYMBOL(__stack_smash_handler);
>
>  extern long __guard __attribute__((weak));
>  EXPORT_SYMBOL(__guard);
> +
> +#ifdef _FORTIFY_SOURCE
> +extern int __sprintf_chk(char *str, int flag, size_t strlen, const char *format);
> +EXPORT_SYMBOL(__sprintf_chk);
> +#endif
> --

Can you please clarify why it's needed? I use FORTIFY_SOURCES on
Linus' tree UML on Ubuntu w/ no problems and w/o this patch...

Thanks,
Vitaliy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/