linux-kernel - Re: [PATCH 00/12] Fix various section mismatches and build errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1309368276.13937.2.camel@mulgrave>
Date:	Wed, 29 Jun 2011 12:24:36 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	Greg KH <greg@...ah.com>, David Miller <davem@...emloft.net>,
	akpm@...ux-foundation.org, alan@...ux.intel.com, bcasavan@....com,
	airlied@...ux.ie, grundler@...isc-linux.org, perex@...ex.cz,
	rpurdie@...ys.net, klassert@...hematik.tu-chemnitz.de,
	tj@...nel.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	linux-scsi@...r.kernel.org, linux-serial@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 00/12] Fix various section mismatches and build errors.

On Wed, 2011-06-29 at 17:19 +0100, Ralf Baechle wrote:
> On Wed, Jun 29, 2011 at 08:14:24AM -0700, Greg KH wrote:
> 
> > 
> > On Wed, Jun 29, 2011 at 08:58:19AM -0500, James Bottomley wrote:
> > > I think we should simply concentrate on __init and __exit; that's where
> > > most of the discard value lies and stop expending huge efforts on the
> > > __devX stuff which adds huge complexity for no real gain.
> > 
> > I have long felt that those __devX markings should just go away as they
> > cause nothing but problems and have no real gain as you point out.
> 
> The suggestion to do that has been floated around before but seems to
> have missed sufficient thrust.  I'm all for it; the manual tagging with
> __devX has not been very efficient on developer time.  I just want to see
> meaningful warnings again over all that noise the current mechanisn may
> produce.

For me, just go ahead and fix the actual problems: so _init sections and
_exit sections that are used from the main body, just strip the
annotations, don't try to change them for _devX ones.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/