linux-kernel - Re: [PATCH] fs: push i_mutex and filemap_write_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110629180939.GA9934@infradead.org>
Date:	Wed, 29 Jun 2011 14:09:39 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Josef Bacik <josef@...hat.com>
Cc:	linux-fsdevel@...r.kernel.org, hch@...radead.org,
	viro@...iv.linux.org.uk, jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into
 ->fsync() handlers

> -int blkdev_fsync(struct file *filp, int datasync)
> +int blkdev_fsync(struct file *filp, loff_t start, loff_t end, int datasync)
>  {
>  	struct inode *bd_inode = filp->f_mapping->host;
>  	struct block_device *bdev = I_BDEV(bd_inode);
> @@ -389,14 +389,10 @@ int blkdev_fsync(struct file *filp, int datasync)
>  	 * i_mutex and doing so causes performance issues with concurrent
>  	 * O_SYNC writers to a block device.
>  	 */
> -	mutex_unlock(&bd_inode->i_mutex);
> -

Now that i_mutex on entry isn't held the comment above can be removed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/