linux-kernel - Re: [PATCH V1] led: pm8xxx: Add pm8xxx leds driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E0B6EE8.9070202@codeaurora.org>
Date:	Wed, 29 Jun 2011 11:28:56 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Anirudh Ghayal <aghayal@...eaurora.org>
CC:	Lars-Peter Clausen <lars@...afoo.de>,
	Richard Purdie <rpurdie@...ys.net>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Trilok Soni <tsoni@...eaurora.org>
Subject: Re: [PATCH V1] led: pm8xxx: Add pm8xxx leds driver

On 06/22/2011 03:49 AM, Anirudh Ghayal wrote:
> +
> +/**
> + * struct pm8xxx_led_data - internal led data structure
> + * @led_classdev - led class device
> + * @id - led index
> + * @led_brightness - led brightness levels
> + * @work - workqueue for led
> + * @lock - to protect the transactions
> + * @reg - cached value of led register
> + */

This isn't kerneldoc notation.

> +fail_id_check:
> +	if (i > 0) {
> +		for (i = i - 1; i >= 0; i--) {
> +			int index = pdata->leds[i].flags;
> +			mutex_destroy(&led[index].lock);
> +			led_classdev_unregister(&led[index].cdev);
> +		}
> +	}

if (i > 0) is redundant here.

> +/**
> + * enum pm8xxx_leds - PMIC8XXX supported led ids
> + * @PM8XXX_ID_LED_KB_LIGHT - keyboard backlight led
> + * @PM8XXX_ID_LED_0 - First low current led
> + * @PM8XXX_ID_LED_1 - Second low current led
> + * @PM8XXX_ID_LED_2 - Third low current led
> + * @PM8XXX_ID_FLASH_LED_0 - First flash led
> + * @PM8XXX_ID_FLASH_LED_0 - Second flash led
> + */
> +

This isn't kerneldoc notation.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/