linux-kernel - Re: [PATCH -tip 10/13] [RESEND]perf probe: Warn when more than two lines are given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E0AB4B5.9040305@hitachi.com>
Date:	Wed, 29 Jun 2011 14:14:29 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	David Ahern <dsahern@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, yrl.pp-manager.tt@...achi.com,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH -tip 10/13] [RESEND]perf probe: Warn when more than two
 lines are given

(2011/06/28 23:15), David Ahern wrote:
> 
> 
> On 06/27/2011 01:27 AM, Masami Hiramatsu wrote:
>> Print warning which warns only the last specified --line option is valid.
>>
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
>> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
>> Cc: Paul Mackerras <paulus@...ba.org>
>> Cc: Ingo Molnar <mingo@...e.hu>
>> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
>> ---
>>
>>  tools/perf/builtin-probe.c |   11 ++++++++---
>>  1 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
>> index 2c0e64d..4f3460a 100644
>> --- a/tools/perf/builtin-probe.c
>> +++ b/tools/perf/builtin-probe.c
>> @@ -134,10 +134,15 @@ static int opt_show_lines(const struct option *opt __used,
>>  {
>>  	int ret = 0;
>>  
>> -	if (str)
>> -		ret = parse_line_range_desc(str, &params.line_range);
>> -	INIT_LIST_HEAD(&params.line_range.line_list);
>> +	if (!str)
>> +		return 0;
>> +
>> +	if (params.show_lines)
>> +		pr_warning("Warning: more than two --line option are"
>> +			   " detected. Only last option is valid.\n");
> 
> This detects a second --line option, but your warning suggests two
> --line options are ok. Should that warning be "more than one --line
> option is"

Oops! Right, thank you!

> 
>>  	params.show_lines = true;
>> +	ret = parse_line_range_desc(str, &params.line_range);
>> +	INIT_LIST_HEAD(&params.line_range.line_list);
>>  
>>  	return ret;
>>  }


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/