linux-kernel - Re: [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTik-k+9=8coWpZO_zToYCm8iHfO3CQ@mail.gmail.com>
Date:	Thu, 30 Jun 2011 16:50:48 +0900
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Kukjin Kim <kgene.kim@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Ben Dooks <ben-linux@...ff.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	dg77.kim@...sung.com,
	함명주 <myungjoo.ham@...il.com>
Subject: Re: [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210,
 S5PC110, and Exynos4

On Wed, Jun 29, 2011 at 10:42 PM, Kukjin Kim <kgene.kim@...sung.com> wrote:
> MyungJoo Ham wrote:
>>
>> In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX
>> register, not ADCCON register. This patch corrects the behavior of
>> Samsung-ADC for such cpus.
>>
>> Signed-off-by: MyungJoo Ham <myungjoo.ham@...sung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
>> --
>> v2: No changes from v1. Resubmitted as a series of patches
>> ---
[]
>>
>>  enum s3c_cpu_type {
>>       TYPE_S3C24XX,
>> -     TYPE_S3C64XX
>> +     TYPE_S3C64XX,
>> +     TYPE_S5P,
>>  };
>
> How about S5PC100? Following is better for next if we cannot distinguish it
> by CPU.
>
> -enum s3c_cpu_type {
> -       TYPE_S3C24XX,
> -       TYPE_S3C64XX
> +enum samsung_adc_type {
> +       TYPE_ADC24,      /* S3C24XX */
> +       TYPE_ADC64,      /* S3C64XX, S5P64X0, S5PC100 */
> +       TYPE_ADCV3      /* S5PV210, EXYNOS4210 */
>  };
> ...
>
> TYPE_ADCV1 and V2?...
> Of course, the name can be changed...

I don't mind about these names as they are just internal values of adc.c.
Anyway, I prefer the last suggestion and I'll use TYPE_ADCV1/V2/V3.

Thanks.

-- 
MyungJoo Ham (함명주), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/