linux-kernel - Re: [PATCH] leds: pca9532: change driver name to be unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110630160615.516c456a@endymion.delvare>
Date:	Thu, 30 Jun 2011 16:06:15 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Riku Voipio <riku.voipio@....fi>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] leds: pca9532: change driver name to be unique

On Thu, 30 Jun 2011 15:36:21 +0200, Wolfram Sang wrote:
> This driver handles the variants pca9530-pca9533, so it chose the name
> "pca953x". However, there is a gpio driver which decided on the same
> name. As a result, those two can't be loaded at the same time. Add a
> subsystem prefix to make the driver name unique. Device matching will
> not suffer, because both are I2C drivers which match using a
> i2c_device_id-table which is not altered.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>

Which is (one of the reasons) why I hate "x" in driver names.

Acked-by: Jean Delvare <khali@...ux-fr.org>

> ---
>  drivers/leds/leds-pca9532.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index d8d3a1e..a2c8746 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -88,7 +88,7 @@ static const struct pca9532_chip_info pca9532_chip_info_tbl[] = {
>  
>  static struct i2c_driver pca9532_driver = {
>  	.driver = {
> -		.name = "pca953x",
> +		.name = "leds-pca953x",
>  	},
>  	.probe = pca9532_probe,
>  	.remove = pca9532_remove,


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/