lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jun 2011 17:11:38 +0200 From: Sascha Hauer <s.hauer@...gutronix.de> To: Arnd Bergmann <arnd@...db.de> Cc: Shawn Guo <shawn.guo@...aro.org>, Ryan Mallon <ryan@...ewatersys.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 3/3] pwm: Add a i.MX23/28 pwm driver On Thu, Jun 30, 2011 at 01:42:35PM +0200, Arnd Bergmann wrote: > On Thursday 30 June 2011, Sascha Hauer wrote: > > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de> > > Hi Sascha, > > The probing looks good to me now. I would have added extra code to avoid > ioremapping the same page multiple times, but I see this as a matter of > different preferences, so I'm fine with that. > > You are still missing a description of the driver, both in the changelog > above and in the Kconfig patch. A small sentence to spell out PWM > in the changelog and to list the devices that will use this driver > would be helpful to the causal reader. Ok, will add. > > Provided that you add that: > > Reviewed-by: Arnd Bergmann <arnd@...db.de> > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > > index 93c1052..5694574 100644 > > --- a/drivers/pwm/Kconfig > > +++ b/drivers/pwm/Kconfig > > @@ -2,11 +2,15 @@ menuconfig PWM > > bool "PWM Support" > > help > > This enables PWM support through the generic PWM framework. > > - You only need to enable this, if you also want to enable > > + You only need to enable this if you also want to enable > > one or more of the PWM drivers below. > > > > If unsure, say N. > > > > I think this hunk should have been in the other first patch. Indeed, will fix. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists