lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 30 Jun 2011 10:06:57 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Andrea Righi <andrea@...terlinux.com>
Cc:	Vivek Goyal <vgoyal@...hat.com>, Jens Axboe <jaxboe@...ionio.com>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-cgroup: fix file names in documentation

On Thu, 30 Jun 2011 17:22:04 +0200 Andrea Righi wrote:

> All the blkio.throttle.* file names are incorrectly reported without
> ".throttle" in the documentation. Fix it.
> 
> Signed-off-by: Andrea Righi <andrea@...terlinux.com>

Applied, thanks.


> ---
>  Documentation/cgroups/blkio-controller.txt |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/cgroups/blkio-controller.txt b/Documentation/cgroups/blkio-controller.txt
> index cd45c8e..84f0a15 100644
> --- a/Documentation/cgroups/blkio-controller.txt
> +++ b/Documentation/cgroups/blkio-controller.txt
> @@ -77,7 +77,7 @@ Throttling/Upper Limit policy
>  - Specify a bandwidth rate on particular device for root group. The format
>    for policy is "<major>:<minor>  <byes_per_second>".
>  
> -        echo "8:16  1048576" > /sys/fs/cgroup/blkio/blkio.read_bps_device
> +        echo "8:16  1048576" > /sys/fs/cgroup/blkio/blkio.throttle.read_bps_device
>  
>    Above will put a limit of 1MB/second on reads happening for root group
>    on device having major/minor number 8:16.
> @@ -90,7 +90,7 @@ Throttling/Upper Limit policy
>          1024+0 records out
>          4194304 bytes (4.2 MB) copied, 4.0001 s, 1.0 MB/s
>  
> - Limits for writes can be put using blkio.write_bps_device file.
> + Limits for writes can be put using blkio.throttle.write_bps_device file.
>  
>  Hierarchical Cgroups
>  ====================
> @@ -286,28 +286,28 @@ Throttling/Upper limit policy files
>  	  specified in bytes per second. Rules are per deivce. Following is
>  	  the format.
>  
> -  echo "<major>:<minor>  <rate_bytes_per_second>" > /cgrp/blkio.read_bps_device
> +  echo "<major>:<minor>  <rate_bytes_per_second>" > /cgrp/blkio.throttle.read_bps_device
>  
>  - blkio.throttle.write_bps_device
>  	- Specifies upper limit on WRITE rate to the device. IO rate is
>  	  specified in bytes per second. Rules are per deivce. Following is
>  	  the format.
>  
> -  echo "<major>:<minor>  <rate_bytes_per_second>" > /cgrp/blkio.write_bps_device
> +  echo "<major>:<minor>  <rate_bytes_per_second>" > /cgrp/blkio.throttle.write_bps_device
>  
>  - blkio.throttle.read_iops_device
>  	- Specifies upper limit on READ rate from the device. IO rate is
>  	  specified in IO per second. Rules are per deivce. Following is
>  	  the format.
>  
> -  echo "<major>:<minor>  <rate_io_per_second>" > /cgrp/blkio.read_iops_device
> +  echo "<major>:<minor>  <rate_io_per_second>" > /cgrp/blkio.throttle.read_iops_device
>  
>  - blkio.throttle.write_iops_device
>  	- Specifies upper limit on WRITE rate to the device. IO rate is
>  	  specified in io per second. Rules are per deivce. Following is
>  	  the format.
>  
> -  echo "<major>:<minor>  <rate_io_per_second>" > /cgrp/blkio.write_iops_device
> +  echo "<major>:<minor>  <rate_io_per_second>" > /cgrp/blkio.throttle.write_iops_device
>  
>  Note: If both BW and IOPS rules are specified for a device, then IO is
>        subjectd to both the constraints.
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ