linux-kernel - Re: [PATCH] media: fix radio-sf16fmr2 build when SND is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201106302036.56468.linux@rainbow-software.org>
Date:	Thu, 30 Jun 2011 20:36:49 +0200
From:	Ondrej Zary <linux@...nbow-software.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-media@...r.kernel.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Hans Verkuil <hverkuil@...all.nl>,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: [PATCH] media: fix radio-sf16fmr2 build when SND is not enabled

On Thursday 30 June 2011 19:31:04 Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> When CONFIG_SND is not enabled, radio-sf16fmr2 build fails with:
> 
> ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> 
> so make this driver depend on SND.

I broke this when converting the driver to use common TEA575x code.
Thanks for finding and fixing it.

> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Hans Verkuil <hverkuil@...all.nl>
> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
> Cc: linux-media@...r.kernel.org
> ---
>  drivers/media/radio/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20110630.orig/drivers/media/radio/Kconfig
> +++ linux-next-20110630/drivers/media/radio/Kconfig
> @@ -201,7 +201,7 @@ config RADIO_SF16FMI
>  
>  config RADIO_SF16FMR2
>  	tristate "SF16FMR2 Radio"
> -	depends on ISA && VIDEO_V4L2
> +	depends on ISA && VIDEO_V4L2 && SND
>  	---help---
>  	  Choose Y here if you have one of these FM radio cards.



-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/