linux-kernel - Re: [PATCH] mmc: dw_mmc: Add the function call for board-specific initialization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4E0C18BD.8000608@samsung.com>
Date:	Thu, 30 Jun 2011 15:33:33 +0900
From:	Jaehoon Chung <jh80.chung@...sung.com>
To:	Seungwon Jeon <tgih.jun@...sung.com>
Cc:	linux-mmc@...r.kernel.org, cjb@...top.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Add the function call for board-specific
 initialization.

Hi Mr.Jeon

This patch is the compiler error.

didn't find host->card_work..

do you want this
queue_work(dw_mci_card_workqueue, &slot->host->card_work); ?


Regards,
Jaehoon Chung


Seungwon Jeon wrote:
> Need to call init() function of dw_mci_board.
> It seems to be omitted to call this function.
> 
> Signed-off-by: Seungwon Jeon <tgih.jun@...sung.com>
> ---
>  drivers/mmc/host/dw_mmc.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a524416..073c420 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1585,6 +1585,15 @@ static void dw_mci_work_routine_card(struct work_struct *work)
>  	}
>  }
> 
> +static irqreturn_t dw_mci_detect_interrupt(int irq, void *dev_id)
> +{
> +	struct dw_mci_slot *slot = dev_id;
> +
> +	queue_work(dw_mci_card_workqueue, &host->card_work);
> +
> +	return IRQ_HANDLED;
> +}
> +
>  static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>  {
>  	struct mmc_host *mmc;
> @@ -1657,6 +1666,8 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>  	} else
>  		regulator_enable(host->vmmc);
> 
> +	host->pdata->init(id, dw_mci_detect_interrupt, host);
> +
>  	if (dw_mci_get_cd(mmc))
>  		set_bit(DW_MMC_CARD_PRESENT, &slot->flags);
>  	else
> --
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/