linux-kernel - Re: linux-next: build failure after merge of the akpm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Jul 2011 20:37:02 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Cong Wang <amwang@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the akpm tree

Hi,

On Fri, 01 Jul 2011 18:10:30 +0800 Cong Wang <amwang@...hat.com> wrote:
>
> 于 2011年07月01日 15:08, Stephen Rothwell 写道:
> >
> > On Fri, 01 Jul 2011 13:32:04 +0800 Cong Wang<amwang@...hat.com>  wrote:
> >>
> >> 于 2011年07月01日 13:19, Stephen Rothwell 写道:
> >>>
> >>> After merging the akpm tree, today's linux-next build (powerpc
> >>> ppc64_defconfig) failed like this:
> >>>
> >>> arch/powerpc/kernel/rtas.c: In function 'rtas_restart':
> >>> arch/powerpc/kernel/rtas.c:655:24: error: 'SYS_RESTART' undeclared (first use in this function)
> >>> arch/powerpc/kernel/rtas.c: In function 'rtas_power_off':
> >>> arch/powerpc/kernel/rtas.c:664:24: error: 'SYS_POWER_OFF' undeclared (first use in this function)
> >>> arch/powerpc/kernel/rtas.c: In function 'rtas_halt':
> >>> arch/powerpc/kernel/rtas.c:674:24: error: 'SYS_HALT' undeclared (first use in this function)
> >>>
> >>> Caused by commit ac050ff2a176 ("It is not necessary to share the same
> >>> notifier.h").
> >>
> >> I think the following patch will fix this.
> >
> > Please find all the other files that need that include as well (there is
> > at least one more).
> >
> 
> Ok, I will do a cross-compilation.

Well, really any file that references any of those defines should be
including linux/reboot.h, now - whether a compilation gets errors or
not.  A change in CONFIG options or different platforms/architectures can
change what file get implictly included.

See Rule 1 in Documentation/SubmitChecklist.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped