linux-kernel - Re: [tip:perf/urgent] perf_event: Return -EINVAL for Offcore Response Events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Jul 2011 11:42:32 -0400 (EDT)
From:	Vince Weaver <vweaver1@...s.utk.edu>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, stable@...nel.org, tglx@...utronix.de,
	mingo@...e.hu
cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] perf_event: Return -EINVAL for Offcore Response
 Events


On Fri, 1 Jul 2011, tip-bot for Vince Weaver wrote:

> Commit-ID:  04bffb83d17c1b93578564f18e02b6cb1c385b40
> Gitweb:     http://git.kernel.org/tip/04bffb83d17c1b93578564f18e02b6cb1c385b40
> Author:     Vince Weaver <vweaver1@...s.utk.edu>
> AuthorDate: Fri, 10 Jun 2011 16:07:52 -0400
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Fri, 1 Jul 2011 10:27:09 +0200
> 
> perf_event: Return -EINVAL for Offcore Response Events


Wait!  Please don't apply this one.

It does indeed Return -EINVAL for Offcore Response Events but also
for *all* RAW events.

I missed that on initial testing, and then I caught the problem but 
couldn't find a simple way to return EINVAL only for config1 being set to 
nonzero.

The code used to shutdown OFFCORE_RESPONSE here is very subtle 
and non-obvious.

Vince


> 
> Return a proper error code when denying raw access to Offcore Response
> events. Right now we return "0" which gives tools the false impression
> that opening the event worked.
> 
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: <stable@...nel.org>
> Link: http://lkml.kernel.org/r/alpine.DEB.2.00.1106101606000.14542@cl320.eecs.utk.edu
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/x86/kernel/cpu/perf_event.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
> index 3a0338b..c6bfa6b 100644
> --- a/arch/x86/kernel/cpu/perf_event.c
> +++ b/arch/x86/kernel/cpu/perf_event.c
> @@ -598,7 +598,7 @@ static int x86_setup_perfctr(struct perf_event *event)
>  	 * there's no sane user-space generalization yet:
>  	 */
>  	if (attr->type == PERF_TYPE_RAW)
> -		return 0;
> +		return -EINVAL;
>  
>  	if (attr->type == PERF_TYPE_HW_CACHE)
>  		return set_ext_hw_attr(hwc, event);
> 
> 

Vince
vweaver1@...s.utk.edu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/