linux-kernel - Re: [PATCH] x86: Add Dell E5420 reboot quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTiktLdMiSa7bOCkrRxmngx-=CONSew@mail.gmail.com>
Date:	Sat, 2 Jul 2011 00:05:33 +0800
From:	Daniel J Blueman <daniel.blueman@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>
Subject: Re: [PATCH] x86: Add Dell E5420 reboot quirk

On 31 May 2011 00:52, Daniel J Blueman <daniel.blueman@...il.com> wrote:
> On 31 May 2011 00:31, H. Peter Anvin <hpa@...or.com> wrote:
>> On 05/30/2011 07:43 AM, Daniel J Blueman wrote:
>>>
>>> Without this patch, rebooting is like Russian roulette; with quite a
>>> few of these laptops in the field, perhaps it is better to enable the
>>> quirk unless you think there may be an issue in the kernel preventing
>>> correct behaviour that I could debug?
>>>
>>> On the other hand, Dell may later fix the BIOS AML (seen with the
>>> excellent fwts) just as the cure for cancer is found. If they do, I'll
>>> buy whiskey too.
>
>> Enabling the quirk is the right thing; however, if ACPI worked I'd have
>> preferred it since we just switched to ACPI as the default.
>
> Indeed - the new and default ACPI reboot method works perfectly in
> 3.0-rc1, whereas with 2.6.39, it didn't, so no further need for this
> patch then.

I slipped up, since after finally now moving on from 2.6.39, I removed
the 'reboot=p' boot parameter; it turns out that 3.0-rc1 through -rc5
do need this workaround; and the BIOS isn't changed. Honest. So, I
didn't double-check that I had booted without it.

Can you queue up the patch please (earlier in the thread)? Probably we
should consider it for stable too, due to the hassle it brings. Let me
know if we should debug would be useful for this problem.

Thanks,
  Daniel
-- 
Daniel J Blueman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/