linux-kernel - Re: [PATCH 08/11] misc: Kconfig and Makefile changes for inv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110701101018.0f02d2f3.rdunlap@xenotime.net>
Date:	Fri, 1 Jul 2011 10:10:18 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Nathan Royer <nroyer@...ensense.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jonathan Cameron <jic23@....ac.uk>,
	Jiri Kosina <jkosina@...e.cz>, Alan Cox <alan@...ux.intel.com>,
	Jean Delvare <khali@...ux-fr.org>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 08/11] misc: Kconfig and Makefile changes for inv_mpu
 driver

On Thu, 30 Jun 2011 19:18:24 -0700 Nathan Royer wrote:

> Signed-off-by: Nathan Royer <nroyer@...ensense.com>
> ---
>  drivers/misc/Kconfig          |    1 +
>  drivers/misc/Makefile         |    1 +
>  drivers/misc/inv_mpu/Kconfig  |   58 +++++++++++++++++++++++++++++++++++++++++
>  drivers/misc/inv_mpu/Makefile |   17 ++++++++++++
>  4 files changed, 77 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/misc/inv_mpu/Kconfig
>  create mode 100644 drivers/misc/inv_mpu/Makefile
> 
> diff --git a/drivers/misc/inv_mpu/Kconfig b/drivers/misc/inv_mpu/Kconfig
> new file mode 100644
> index 0000000..fdfa7a6
> --- /dev/null
> +++ b/drivers/misc/inv_mpu/Kconfig
> @@ -0,0 +1,58 @@
> +
> +menuconfig: INV_SENSORS

hm, that ':' there happens to work, but the syntax description for
"menuconfig" does not show it as allowed, and no other Kconfig files use
a colon there, so please drop it.

Oh, also not "default y", please.

> +	tristate "Motion Processing Unit"
> +	depends on I2C
> +	default y
> +
> +if INV_SENSORS
> +
> +choice
> +	prompt "MPU Master"
> +	depends on I2C && INV_SENSORS
> +	default MPU_SENSORS_MPU3050
> +
> +config MPU_SENSORS_MPU3050
> +	bool "MPU3050"
> +	depends on I2C
> +	select MPU_SENSORS_MPU3050_GYRO
> +	help
> +	  If you say yes here you get support for the MPU3050 Gyroscope driver
> +	  This driver can also be built as a module.  If so, the module
> +	  will be called mpu3050.
> +
> +config MPU_SENSORS_MPU6050A2
> +	bool "MPU6050A2"
> +	depends on I2C
> +	select MPU_SENSORS_MPU6050_GYRO
> +	help
> +	  If you say yes here you get support for the MPU6050A2 Gyroscope driver
> +	  This driver can also be built as a module.  If so, the module
> +	  will be called mpu6050a2.
> +
> +config MPU_SENSORS_MPU6050B1
> +	bool "MPU6050B1"
> +	select MPU_SENSORS_MPU6050_GYRO
> +	depends on I2C
> +	help
> +	  If you say yes here you get support for the MPU6050 Gyroscope driver
> +	  This driver can also be built as a module.  If so, the module
> +	  will be called mpu6050b1.
> +
> +endchoice
> +
> +choice
> +	prompt "Gyroscope Type"
> +	depends on I2C && INV_SENSORS
> +	default MPU_SENSORS_MPU3050_GYRO
> +
> +config MPU_SENSORS_MPU3050_GYRO
> +	bool "MPU3050 built in gyroscope"
> +	depends on MPU_SENSORS_MPU3050
> +
> +config MPU_SENSORS_MPU6050_GYRO
> +	bool "MPU6050 built in gyroscope"
> +	depends on MPU_SENSORS_MPU6050B1 || MPU_SENSORS_MPU6050A2
> +
> +endchoice
> +
> +endif #INV_SENSORS



---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/