linux-kernel - Re: [PATCH RFC 1/2 ] [x86] Modify comments and clean up code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110701202139.GB20865@elte.hu>
Date:	Fri, 1 Jul 2011 22:21:39 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	ling.ma@...el.com, hpa@...or.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 1/2 ] [x86] Modify comments and clean up code.


* Andi Kleen <andi@...stfloor.org> wrote:

> ling.ma@...el.com writes:
> 
> > From: Ma Ling <ling.ma@...el.com>
> >
> > Modern CPU use fast-string instruction to accelerate copy performance,
> > by combining data into 128bit, so we modify comments and code style.
> 
> The description has nothing to do with the patch.
> 
> As far as I can tell the patch just renames one symbol
> and changes all white space. Not fully sure what the point of it 
> is. 
> 
> But normally white space change patches are not supposed to have 
> any other changes because the other changes embedded in them are 
> impossible to review.

Non-functional cleanups can go into the same patch as whitespace 
cleanups, as long as the generated object code does not change.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/