linux-kernel - Re: [patch 03/11] blackfin/irqs: Do not trace arch_local_{*,irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMjpGUdnA5qd98nfB8UR-TGnCYm4F-7NVPobjWoAxXYPd4Vv=A@mail.gmail.com>
Date:	Sat, 2 Jul 2011 12:39:56 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 03/11] blackfin/irqs: Do not trace arch_local_{*,irq_*} functions

On Sat, Jul 2, 2011 at 12:11, Steven Rostedt wrote:
> On Sat, 2011-07-02 at 02:50 -0400, Mike Frysinger wrote:
>> On Fri, Jul 1, 2011 at 23:04, Steven Rostedt wrote:
>> > Do not trace arch_local_save_flags(), arch_local_irq_*() and friends.
>> > Although they are marked inline, gcc may still make a function out of
>> > them and add it to the pool of functions that are traced by the function
>> > tracer. This can cause undesirable results (kernel panic, triple faults,
>> > etc).
>> >
>> > Add the notrace notation to prevent them from ever being traced.
>>
>> what about putting the markings in include/asm-generic/irqflags.h ?
>> then you wouldnt have to update every arch (or at least, not as much).
>
> One of my patches do that, but it only helps superH, as that's the only
> arch that uses that header and implements function tracing.

hmm, i thought Blackfin was using that too.  guess i'll have to fix that ;).
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/