linux-kernel - Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Jul 2011 20:42:43 +0400
From:	Solar Designer <solar@...nwall.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	kernel-hardening@...ts.openwall.com,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	James Morris <jmorris@...ei.org>,
	Namhyung Kim <namhyung@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()

On Fri, Jul 01, 2011 at 03:20:51PM +0100, Alan Cox wrote:
> > $ dmesg | tail
> > ...
> > [16291.982492] init[21579]: segfault at 0 ip 00007f527186028a sp 00007fff08251dd8 error 4 in libc-2.11.1.so[7f52717d8000+17a000]
> > [16379.001357] fail[21586]: segfault at 0 ip 00007f332831028a sp 00007fffc52de568 error 4 in libc-2.11.1.so[7f3328288000+17a000]
> > $ 
> > (see 1234 => init change)
> > 
> > As you see here, the previous log entry was showed not as it was
> > initally logged.  Core dump message was chosen fully arbitrary, just to
> > show that some specific part of it can be "edited".
> 
> Your syslog daemon appears to need improvement

syslogd definitely should (and does) perform escaping of control chars
for logs written through it.

> and that would be the right fix for dmesg etc.

How?  We can't realistically expect everyone to stop invoking dmesg
directly.  Moreover, this is sometimes useful, although someone who is
aware of the risk and who cares about it would do "dmesg | less".  The
problem is that most people are not aware, and we can't change that.

> The other case is the actual printk direct to console case, particularly
> on a serial port. That one actually has more potential for actual
> annoyance.

Right.

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/