linux-kernel - Re: [PATCH 0/11] dynamic_debug: allow multiple pending queries on boot-line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO+b5-p26Ch73DeZR4OMmvbxsVuP0j6t2Htjsae24NeqhspHtw@mail.gmail.com>
Date:	Sun, 3 Jul 2011 10:19:55 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	linux-kernel@...r.kernel.org, gnb@...h.org, jbaron@...hat.com,
	gregkh@...e.de
Subject: Re: [PATCH 0/11] dynamic_debug: allow multiple pending queries on boot-line

On Tue, Jun 28, 2011 at 9:09 AM, Jim Cromie <jim.cromie@...il.com> wrote:
> This patchset extends dynamic-debug facility to allow
> use of pr_debug() within a loadable module's module_init()
> function.

Can you please clean up checkpatch complaints before resubmitting ?
This is what checkpatch reports on the current patch set:

ERROR: code indent should use tabs where possible
#125: FILE: lib/dynamic_debug.c:119:
+        sprintf(prbuf_query,$

WARNING: please, no spaces at the start of a line
#125: FILE: lib/dynamic_debug.c:119:
+        sprintf(prbuf_query,$

ERROR: code indent should use tabs where possible
#211: FILE: lib/dynamic_debug.c:357:
+        sprintf(prbuf_query,$

WARNING: please, no spaces at the start of a line
#211: FILE: lib/dynamic_debug.c:357:
+        sprintf(prbuf_query,$

ERROR: trailing whitespace
#442: FILE: lib/dynamic_debug.c:756:
+^I^I^I$

ERROR: trailing whitespace
#469: FILE: lib/dynamic_debug.c:813:
+^I^I$

ERROR: else should follow close brace '}'
#483: FILE: lib/dynamic_debug.c:827:
+               }
+               else if (verbose)

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/