| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1309657621-21711-1-git-send-email-chrisf@ijw.co.nz> Date: Sun, 3 Jul 2011 13:47:01 +1200 From: Chris Forbes <chrisf@....co.nz> To: Greg Kroah-Hartman <gregkh@...e.de> Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Chris Forbes <chrisf@....co.nz> Subject: [PATCH] drivers: staging: iio: adc: fix uninitialized use Fixed an uninitialized variable access. In the first two error paths in max1363_probe(), 'st' is not yet initialized, but its 'reg' member is accessed anyway. This would most likely crash. The intended value for st->reg *is* available at that point in 'reg', so just use that directly. Signed-off-by: Chris Forbes <chrisf@....co.nz> --- drivers/staging/iio/adc/max1363_core.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c index 98cebd2..ebecf14 100644 --- a/drivers/staging/iio/adc/max1363_core.c +++ b/drivers/staging/iio/adc/max1363_core.c @@ -1335,11 +1335,11 @@ error_free_device: else iio_device_unregister(indio_dev); error_disable_reg: - if (!IS_ERR(st->reg)) - regulator_disable(st->reg); + if (!IS_ERR(reg)) + regulator_disable(reg); error_put_reg: - if (!IS_ERR(st->reg)) - regulator_put(st->reg); + if (!IS_ERR(reg)) + regulator_put(reg); return ret; } -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists