linux-kernel - Re: [PATCH 2/7] debugfs: add debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110703162329.GA28131@suse.de>
Date:	Sun, 3 Jul 2011 09:23:29 -0700
From:	Greg KH <gregkh@...e.de>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 2/7] debugfs: add debugfs_create_int

On Sun, Jul 03, 2011 at 11:16:16PM +0900, Akinobu Mita wrote:
> Introduce debugfs_create_int() for creating a debugfs file that is used to
> read and write an int value.

Um, what's wrong with the existing s32 and s64 versions that debugfs
already provides?

userspace doesn't know what "int" means for the kernel as it might be
running in 32bit mode with a 64bit kernel.  That is why this isn't a
good idea, so please convert your other patch to use the existing api
and change the variable type in your patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/