linux-kernel - Re: [PATCH] gma500: fix compiler warnings and format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107041109410.24059@swampdragon.chaosbits.net>
Date:	Mon, 4 Jul 2011 11:10:07 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	linux-kernel@...r.kernel.org,
	Thomas Hellstrom <thomas@...gstengraphics.com>,
	Alan Cox <alan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org
Subject: Re: [PATCH] gma500: fix compiler warnings and format string

On Sun, 3 Jul 2011, Alan Cox wrote:

> On Sun, 3 Jul 2011 09:16:13 +0200 (CEST)
> Jesper Juhl <jj@...osbits.net> wrote:
> 
> > This patch fixes these compiler warnings:
> > 
> >   CC      drivers/staging/gma500/psb_gtt.o
> > drivers/staging/gma500/psb_gtt.c: In function ‘psb_gtt_insert’:
> > drivers/staging/gma500/psb_gtt.c:81:33: warning: unused variable ‘dev_priv’ [-Wunused-variable]
> > drivers/staging/gma500/psb_gtt.c: In function ‘psb_gtt_pin’:
> > drivers/staging/gma500/psb_gtt.c:237:2: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized]
> > 
> > It also fixes up the format string used in DRM_DEBUG() in
> > drivers/staging/gma500/psb_gtt.c:psb_gtt_init() - the string required
> > two arguments but only one was supplied.
> > 
> > While reading through the file I also deleted what trailing whitespace
> > I encountered.
> 
> Unfortunately this file doesn't even exist in the working tree any more.
> Please wait until Greg has taken the patch set I sent him to replace the
> one that didn't apply, and the patch series after that (and quite
> possibly the one after that assuming I can get Cedartrail to work next
> week).
> 
Ok. Thank you for the info. I'll leave gma500 alone for a couple of weeks.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.