linux-kernel - Re: [PATCH 3/6] x86,64: Simplify save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jul 2011 14:59:38 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Jan Beulich <JBeulich@...ell.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 3/6] x86,64: Simplify save_regs()

On Mon, Jul 04, 2011 at 08:20:51AM +0100, Jan Beulich wrote:
> >  ENTRY(save_rest)
> >  	PARTIAL_FRAME 1 REST_SKIP+8
> > @@ -791,7 +781,7 @@ END(interrupt)
> >  	/* reserve pt_regs for scratch regs and rbp */
> >  	subq $ORIG_RAX-RBP, %rsp
> >  	CFI_ADJUST_CFA_OFFSET ORIG_RAX-RBP
> > -	call save_args
> > +	SAVE_ARGS_IRQ
> >  	PARTIAL_FRAME 0
> 
> With the above CFI adjustments all looking correct, this PARTIAL_FRAME
> directive now is at best redundant, and hence should be removed.

Indeed, will fix.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/