linux-kernel - Re: [PATCH 1/2] EHCI : introduce a common ehci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1107041146130.12242-100000@netrider.rowland.org>
Date:	Mon, 4 Jul 2011 11:47:45 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	matthieu castet <castet.matthieu@...e.fr>
cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH 1/2] EHCI : introduce a common ehci_setup

On Sun, 3 Jul 2011, matthieu castet wrote:

> > Instead of putting this routine in ehci-hcd.c, where it will silently 
> > use up unnecessary codespace on thousands or millions of desktop 
> > systems, why not put it into a new separate source file?  Then the
> > SOC drivers can #include that file.
> Ok if you prefer that.
> But if we allow someday to built more than one
> SOC driver at a time (this will come for distribution doing generic arm
> kernel or case like [1]). How it will work ? 

Good point.

> Also because the function is static, the compiler will remove
> it, if it is not used. So it won't use extra codespace on desktop.

Ah, I hadn't thought of that.  Thanks for pointing it out.  Okay, you 
can add my Acked-by to this patch.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/