linux-kernel - Re: module: sysfs - add 'uevent' file to allow coldplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPXgP117WLtEX7ecrr9rs7HP0ZYkh25JmKbRj7YRuvGVw359PA@mail.gmail.com>
Date:	Mon, 4 Jul 2011 17:56:37 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: module: sysfs - add 'uevent' file to allow coldplug

On Mon, Jul 4, 2011 at 07:05, Rusty Russell <rusty@...tcorp.com.au> wrote:
> On Fri, 1 Jul 2011 05:07:41 +0200, Kay Sievers <kay.sievers@...y.org> wrote:
>> On Thu, Jun 23, 2011 at 13:24, Kay Sievers <kay.sievers@...y.org> wrote:
>> > On Thu, Jun 23, 2011 at 02:27, Rusty Russell <rusty@...tcorp.com.au> wrote:
>> >> On Wed, 22 Jun 2011 12:17:49 +0200, Kay Sievers <kay.sievers@...y.org> wrote:
>> >>> On Wed, Jun 22, 2011 at 04:00, Rusty Russell <rusty@...tcorp.com.au> wrote:
>> >> I'd prefer that patch first, I think: it's a sensible cleanup.
>> >
>> > You want the patch split up in two? You want to remove the mod
>> > parameter somehow?
>>
>> Can we get these 20 lines of code sorted out please? :)
>
> An odd question, since I was waiting for you to do exactly that!

Oh, I was just waiting for your answer to the earlier question 6 lines
above here. :)

> Rather than go around again, I have:
> 1) Split the patch into one which changes the attr functions, and one
>   which adds the uevent file.
> 2) Fixed the title of the (second) patch to "module: add
>   /sys/module/<name>/uevent files"
> 3) Fixed up the three checkpatch.pl errors (sure, 2 were just code
>   moves, but we're slowly neatening things).
>
> Here they are below, back-to-back.

Great. Thanks a lot for doing this.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/