linux-kernel - Re: [PATCH 0/6+1] ARM: EXYNOS4: SYSMMU: Improvements on SYSMMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jul 2011 08:38:17 +0900
From:	KyongHo Cho <pullip.cho@...sung.com>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Joerg Roedel <joro@...tes.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Sanghyun Lee <sanghyun75.lee@...sung.com>,
	Ilho Lee <ilho215.lee@...sung.com>,
	Kwanghyun La <nala.la@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH 0/6+1] ARM: EXYNOS4: SYSMMU: Improvements on SYSMMU driver

Hi.
On Mon, Jul 4, 2011 at 3:47 PM, Marek Szyprowski
<m.szyprowski@...sung.com> wrote:
> Hello,
>
> I really don't get why do You persist in creating one monster platform
> device with resources for ALL SYSMMU/IOMMU controllers that are available
> on Exynos4 CPU. We (SPRC, see Andrzej's SYSMMU patches) already proposed
> a clean solution for making the SYSMMU controllers independent of each
> other as well as making the main SYSMMU driver simpler and more
> independent of the particular Exynos4 platform definition. In Linux
> device model if the device/controller exist in the system in more than
> one instance, there should by one generic driver for it and a set of
> platform definitions for each instance.
>
Did you find this patch? "[PATCH 3/6] ARM: EXYNOS4: SYSMMU"
I Cced you because it includes your suggestion.

> Here is the link to our SYSMMU updated driver (implementing common
> iommu API):
> http://www.spinics.net/lists/linux-samsung-soc/msg04508.html
> The driver still needs some cleanup, but this has been delayed until
> the dma-mapping framework update is finished.
>
> I also don't get why do you want to keep the completely custom sysmmu
> driver and implement iommu API on top of it. Is it really required for
> anything? Mainline kernel is not a place for custom APIs if there is
> already a common, generic one.

I did not exposed any custom API.
The global function in the last patch is just for IOMMU API implemenation.
The header file in the last patch is not for the device drivers but
for the IOMMU API implementation.
Actually, they can be merged into one single file.
But I just wanted to change the kernel code stepwise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/